This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb5ccfeb6bfbb: [lldb] Add image dump pcm-info command
(authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
kastiglione updated this revision to Diff 444057.
kastiglione added a comment.
simplify error handling by checking for .pcm extension
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129456/new/
https://reviews.llvm.org/D129456
Files:
clang/include
kastiglione updated this revision to Diff 443830.
kastiglione added a comment.
added error handling
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129456/new/
https://reviews.llvm.org/D129456
Files:
clang/include/clang/Frontend/FrontendActions.h
kastiglione added a comment.
@JDevlieghere I had it as `dump pcm` at first, but switched it to `pcm-info`
for two reasons
1. it doesn't dump the whole pcm, the actual ast itself is not dumped
2. to match the clang flag `-module-file-info`
I agree that `pcm` is better, but I was worried it would
JDevlieghere added a comment.
[bikeshedding] `pcm-info` seems a little odd. Do we have other command that end
with `-info`? `target modules dump` already sounds like you're about to dump
some kind of "info". What about just `pcm`? [/bikeshedding]
Repository:
rG LLVM Github Monorepo
CHANGES
kastiglione added a reviewer: Michael137.
kastiglione added inline comments.
Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37
+
+breakpoint()
+self.expect(
mib wrote:
> Left over ?
yep thanks!
Repository:
rG LLVM G
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM with a comment
Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37
+
+breakpoint()
+self.expect(
Left over ?
Repos
