ellis abandoned this revision.
ellis added a comment.
The function `__clang_call_terminate` seems to be a special case that clang
builds itself. This diff might be too much for this rare specific case. Closing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
ellis planned changes to this revision.
ellis added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896
+ if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone)
+if (isProfileInstrExcluded(F, SourceLocation()))
+ F->addFnAttr(llvm:
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129413/new/
https://reviews.llvm.org/D129413
___
ellis added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896
+ if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone)
+if (isProfileInstrExcluded(F, SourceLocation()))
+ F->addFnAttr(llvm::Attribute::NoProfile);
phosek added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896
+ if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone)
+if (isProfileInstrExcluded(F, SourceLocation()))
+ F->addFnAttr(llvm::Attribute::NoProfile);
---
ellis created this revision.
Herald added a project: All.
ellis retitled this revision from "[instrprof] Allow compiler generated
functions in SCL" to "[InstrProf] Allow compiler generated functions in SCL".
ellis edited the summary of this revision.
ellis added reviewers: kyulee, phosek.
ellis pu
