This revision was automatically updated to reflect the committed changes.
Closed by commit rG07df9e918e3f: [NFC] Minor cleanup of usage of FloatModeKind
with bitmask enums (authored by jolanta.jensen).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D12
tahonermann added inline comments.
Comment at: clang/include/clang/Basic/TargetInfo.h:894
bool useObjCFPRetForRealType(FloatModeKind T) const {
-return RealTypeUsesObjCFPRetMask & llvm::BitmaskEnumDetail::Underlying(T);
+return (int)((FloatModeKind)RealTypeUsesObjCFPRe
jolanta.jensen added inline comments.
Comment at: clang/include/clang/Basic/TargetInfo.h:894
bool useObjCFPRetForRealType(FloatModeKind T) const {
-return RealTypeUsesObjCFPRetMask & llvm::BitmaskEnumDetail::Underlying(T);
+return (int)((FloatModeKind)RealTypeUsesObjCF
tahonermann accepted this revision.
tahonermann added a comment.
This revision is now accepted and ready to land.
Looks good, thank you for following up @jolanta.jensen!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129373/new/
https://reviews.llvm
shafik added inline comments.
Comment at: clang/include/clang/Basic/TargetInfo.h:894
bool useObjCFPRetForRealType(FloatModeKind T) const {
-return RealTypeUsesObjCFPRetMask & llvm::BitmaskEnumDetail::Underlying(T);
+return (int)((FloatModeKind)RealTypeUsesObjCFPRetMask
jolanta.jensen updated this revision to Diff 443258.
jolanta.jensen added a comment.
Removing a tab.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129373/new/
https://reviews.llvm.org/D129373
Files:
clang/include/clang/Basic/TargetInfo.h
clang
jolanta.jensen created this revision.
Herald added a project: All.
jolanta.jensen requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D129373
Files:
clang/include/clang/Basic/Ta
