sylvestre.ledru added a comment.
This was merged here: https://reviews.llvm.org/D23317
we can close this review
https://reviews.llvm.org/D12921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Lets says this: I am not happy about it and wouldn't allow it if it was
added now. However, *removing* it actually has additional costs, so I am
not inclined to do so now.
On Thu, Sep 17, 2015 at 9:52 PM, strager wrote:
> strager added a comment.
>
> Should we remove `ObjCSpaceBeforeProtocolList
strager added a comment.
Should we remove `ObjCSpaceBeforeProtocolList`? It has the same problem as the
`SpaceAfterTemplateKeyword` I am introducing.
http://reviews.llvm.org/D12921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
On Thu, Sep 17, 2015 at 12:17 PM, Paul Hoad
wrote:
> MyDeveloperDay added a comment.
>
> > The point here that it this space is utterly irrelevant
>
>
> So I totally take the point but if it doesn't matter then why does
> clang-format automatically add one to my "template<>" why not simply leave
MyDeveloperDay added a comment.
> The point here that it this space is utterly irrelevant
So I totally take the point but if it doesn't matter then why does clang-format
automatically add one to my "template<>" why not simply leave it alone?
> We never intended clang-format to provide control
The most important costs are: Maintenance and discoverability of options.
The point here that it this space is utterly irrelevant, it doesn't make a
readability difference ever. Most codebases are inconsistent about it
anyway and I haven't seen a style guide even talking about this.
We never inte
MyDeveloperDay added a comment.
Oh and we might want to run clang-format by the guys at http://cppreference.com
seems they don't like the space either! just saying
http://reviews.llvm.org/D12921
___
cfe-commits mailing list
cfe-commits@lists.
MyDeveloperDay added a subscriber: MyDeveloperDay.
MyDeveloperDay added a comment.
This looks like a good small change.
What is interesting to me is that even the twiki page about template is
inconsistent in its style (https://en.wikipedia.org/wiki/Template_(C%2B%2B)),
so its not like there is
djasper added a comment.
This has come up before and the decision was that this is not important enough
to meet the bar for an additional clang-format option. clang-format options
have a certain cost and this specific space is so entirely unimportant that we
don't want to pay it.
We have tried
strager created this revision.
strager added a reviewer: djasper.
strager added subscribers: cfe-commits, abdulras, sas.
Herald added a subscriber: klimek.
Some styles don't put a space between 'template' and the
opening '<'. Introduce SpaceAfterTemplateKeyword which, when
set to false, causes 'te
10 matches
Mail list logo
