[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-26 Thread Chuanqi Xu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc73adbad6a99: [clang] [docs] Update the changes of C++20 Modules in clang15 (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-26 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D129138#3674619 , @iains wrote: > In D129138#3670708 , @ChuanqiXu > wrote: > >> @iains I'm going to

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-24 Thread Iain Sandoe via Phabricator via cfe-commits
iains added a comment. In D129138#3670708 , @ChuanqiXu wrote: > @iains I'm going to land this in next Monday if all the dependent patch > landed. Do you feel good with this? I am not sure if we will get p1815 part 1 landed (effectively today) - and, of

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-21 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. @iains I'm going to land this in next Monday if all the dependent patch landed. Do you feel good with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new/ https://reviews.llvm.org/D129138 ___ cfe-commits

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-10 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added inline comments. Comment at: clang/www/cxx_status.html:1183 https://wg21.link/p1874r1";>P1874R1 -Partial +Clang 15 avogelsgesang wrote: > should this be `class="unreleased"` instead of `class="full"`? At least this

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-10 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 443549. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new/ https://reviews.llvm.org/D129138 Files: clang/docs/ReleaseNotes.rst clang/www/cxx_statu

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-09 Thread Adrian Vogelsgesang via Phabricator via cfe-commits
avogelsgesang added inline comments. Comment at: clang/www/cxx_status.html:1183 https://wg21.link/p1874r1";>P1874R1 -Partial +Clang 15 should this be `class="unreleased"` instead of `class="full"`? At least this is what other pla

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-06 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D129138#3632128 , @iains wrote: > I would not expect to add all this information to the release notes, or any > of the phab links - just single lines to say that paper numbers are

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-06 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 442761. ChuanqiXu added a comment. Update cxx_status.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new/ https://reviews.llvm.org/D129138 Files: clang/docs/ReleaseNotes.rst clang/www/cxx_status.html Index: clang/www/cxx_status.ht

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-06 Thread H. Vetinari via Phabricator via cfe-commits
h-vetinari added inline comments. Comment at: clang/docs/ReleaseNotes.rst:472-476 +- Implemented `P1103R3: Merging Modules `_. +- Implemented `P1779R3: ABI isolation for member functions `_. +- Implemented `P1874R1: Dynamic I

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-06 Thread Iain Sandoe via Phabricator via cfe-commits
iains added a comment. I would not expect to add all this information to the release notes, or any of the phab links - just single lines to say that paper numbers are implemented - the details are just to help us track the situation up to 26th July. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-06 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D129138#3631912 , @iains wrote: > Perhaps we could be a little more bold about the completeness of the > implementation (at least, w.r.t the base paper `P1103`) - we pass the > relevant test cases. I added the wording like

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-06 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 442487. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new/ https://reviews.llvm.org/D129138 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-06 Thread Iain Sandoe via Phabricator via cfe-commits
iains added a comment. Perhaps we could be a little more bold about the completeness of the implementation (at least, w.r.t the base paper `P1103`) - we pass the relevant test cases. As for the follow-on papers, I think we have more that can be added notes below: There are some test cases to be

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Wording looks fine to me, though unsure if this is a complete/accurate list for obvious reasons. If @iains can take a quick look, it woudl be greatly appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/n

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

2022-07-05 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, aaron.ballman, erichkeane. ChuanqiXu added a project: clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since clang15