[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2db2a4e11240: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209 (authored by peterwaller-arm). Repository: rG LLVM Github Monorepo CH

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm updated this revision to Diff 442264. peterwaller-arm added a comment. s/p0-p4/p0-p3/, thanks for the keen eye, rsandifo-arm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135 Files: clang

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

rsandifo-arm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:503 +- Targeting AArch64, since D127209 LLVM now only preserves the z8-z23 + and p4-p15 registers across a call if the registers z0-z7 or p0-p4 are + used to pass data into or out of a subroutine. The n

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135 ___ cfe-commits mailing list cfe-commi

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm updated this revision to Diff 442253. peterwaller-arm marked an inline comment as done. peterwaller-arm edited the summary of this revision. peterwaller-arm added a comment. - Update commit message: "This affects" -> "The fix affects" Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm marked an inline comment as done. peterwaller-arm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:503 +- Targeting AArch64, LLVM now only preserves the z8-z23 registers across + a call if the registers z0-z7 are used to pass data into or out of a +

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm updated this revision to Diff 442251. peterwaller-arm added a comment. - Cite D127209 in the release note per tschuett comment. - Be more specific about p0-p4, remove 'by analogy', per rsandifo-arm comment. - Clarify 9th argument or greater, per

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett added a comment. > My intent was to express that the issue is present where it's the 9th or > later arguments. So I take from that that it does not matter if arguments 1-8 were all integers and so did not get put in SIMD/floating point registers. I think I am confusing what the A

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

rsandifo-arm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:503 +- Targeting AArch64, LLVM now only preserves the z8-z23 registers across + a call if the registers z0-z7 are used to pass data into or out of a + subroutine. This new behavior now matches the AAPCS

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

tschuett added a comment. Could you cite a Diff where this was changed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135 ___ cfe-commits mailing list cfe-commits

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm added a comment. In D129135#3629860 , @peterwaller-arm wrote: > but I can't identify a specific worse issue at present. Thinking a little harder, one breaking case is where a callee-compiled-with-wrong-logic looks at its signature, conc

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm added a comment. In D129135#3629833 , @DavidSpickett wrote: > From reading the release note my understanding is that before this fix the > caller of a function would store `z0-z7` in situations where it did not need > to. I believe you

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett added a comment. From reading the release note my understanding is that before this fix the caller of a function would store `z0-z7` in situations where it did not need to. Which seems low impact unless you were doing something that read the previous stack frame (but nevertheless

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135 ___

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm created this revision. peterwaller-arm added reviewers: rsandifo-arm, kristof.beyls. Herald added subscribers: ctetreau, tschuett. Herald added a project: All. peterwaller-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.