This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGed801ad5e5fe: [Clang] Use metadata to make identifying
embedded objects easier (authored by jhuber6).
Changed prior to commit:
https://reviews.llv
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129033/new/
https://reviews.llvm.org/D129033
___
jhuber6 updated this revision to Diff 442926.
jhuber6 added a comment.
Updating to use `objects` and adding documentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129033/new/
https://reviews.llvm.org/D129033
Files:
clang/test/Frontend/embe
jdoerfert added a comment.
Generally makes sense, some notes though
Comment at: clang/test/Frontend/embed-object.ll:17
+
+; CHECK: !llvm.embedded.object = !{![[METADATA_1:[0-9]+]],
![[METADATA_2:[0-9]+]]}
+; CHECK: ![[METADATA_1]] = !{ptr @[[OBJECT_1]], !".llvm.offloading"}
--
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, JonChesterfield, ABataev, MaskRay,
tianshilei1992.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscriber
