Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-23 Thread John Brawn via cfe-commits
john.brawn closed this revision. john.brawn added a comment. Committed in r248378. Repository: rL LLVM http://reviews.llvm.org/D12903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-23 Thread John Brawn via cfe-commits
john.brawn added a comment. In http://reviews.llvm.org/D12903#251361, @rengolin wrote: > In http://reviews.llvm.org/D12903#249406, @thakis wrote: > > > Also also, this approach fundamentally doesn't work on Windows. > > > I don't think it's supposed to, anyway. :) Actually, I think it can work

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-22 Thread Renato Golin via cfe-commits
rengolin added a comment. In http://reviews.llvm.org/D12903#249406, @thakis wrote: > Also also, this approach fundamentally doesn't work on Windows. I don't think it's supposed to, anyway. :) Repository: rL LLVM http://reviews.llvm.org/D12903

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-19 Thread Nico Weber via cfe-commits
thakis added a subscriber: thakis. thakis added a comment. Is the idea that this loads plugins that link against clang's C++ api? That api isn't considered stable, so not having an "official" flag for this always looked by design to me. Also, C++ doesn't make for a good ABI. Also also, this app

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-18 Thread Richard Smith via cfe-commits
On Fri, Sep 18, 2015 at 8:22 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > compnerd accepted this revision. > compnerd added a reviewer: compnerd. > compnerd added a comment. > This revision is now accepted and ready to land. > > Looks fine minus the one thing that

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-18 Thread Saleem Abdulrasool via cfe-commits
compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Looks fine minus the one thing that needs a quick look at. Comment at: include/clang/Driver/Options.td:952 @@ -951,1 +951,3 @@ def fn

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-18 Thread Renato Golin via cfe-commits
rengolin added a comment. Shouldn't we use -fplugin in the driver as well? Then translate to -load in cc1? Repository: rL LLVM http://reviews.llvm.org/D12903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-18 Thread John Brawn via cfe-commits
john.brawn added a comment. In http://reviews.llvm.org/D12903#248453, @compnerd wrote: > Do you know if GCC requires the = or can you do -fplugin name.so ? GCC requires the =, or at least GCC 5.1.0 does when I tested it (you get "gcc: error: name.so: No such file or directory" and "gcc: error:

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-17 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. Do you know if GCC requires the = or can you do -fplugin name.so ? Repository: rL LLVM http://reviews.llvm.org/D12903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

2015-09-17 Thread John Brawn via cfe-commits
john.brawn retitled this revision from "Allow the -load option in the driver and pass it through to -cc1" to "Add -fplugin=name.so option to the driver". john.brawn updated the summary for this revision. john.brawn updated this revision to Diff 35014. john.brawn added a comment. Rename option fro