[PATCH] D129014: rewording static_assert to more generic static assertion

2022-07-19 Thread Muhammad Usman Shahid via Phabricator via cfe-commits
Codesbyusman added a comment. *ERR_CLOSED: This revision has already been closed* @Shivam Gupta https://reviews.llvm.org/D129014>+public+5e9f0937aab6a...@reviews.llvm.org> can not update the patch. it seems it is closed. F23843528: image003.png F23843527: i

Re: [PATCH] D129014: rewording static_assert to more generic static assertion

2022-07-02 Thread Muhammad Usman Shahid via cfe-commits
Ok ... I am working on the tests I will update it On Sat, Jul 2, 2022, 7:35 AM Shivam Gupta via Phabricator < revi...@reviews.llvm.org> wrote: > xgupta added a comment. > > Running check-clang after applying the patch, results into 36 failed test > cases. Please update them all. > Also add a desc

[PATCH] D129014: rewording static_assert to more generic static assertion

2022-07-01 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added a comment. Running check-clang after applying the patch, results into 36 failed test cases. Please update them all. Also add a description of patch motivation(via the Edit Revision option on the top) for why you are making the changes (like any wrong behavior you are seeing etc).

[PATCH] D129014: rewording static_assert to more generic static assertion

2022-07-01 Thread Muhammad Usman Shahid via Phabricator via cfe-commits
Codesbyusman created this revision. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129014 Files: clang/include/clang/Basic/Diagno