This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea61750c35a1: [NFC] Refactor llvm::zlib namespace (authored
by ckissane).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:/
ckissane marked 5 inline comments as done.
ckissane added a comment.
mark some handled comments done
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128953/new/
https://reviews.llvm.org/D128953
___
cfe-com
ckissane updated this revision to Diff 443006.
ckissane added a comment.
- chore: delete an excess blank line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128953/new/
https://reviews.llvm.org/D128953
Files:
clang-tools-extra/clangd/index/Serial
ckissane updated this revision to Diff 443005.
ckissane added a comment.
- Merge branch 'ckissane.refactor-compression.part-0' of
github.com:ckissane/llvm-project into ckissane.refactor-compression.part-0
- Merge branch 'main' into ckissane.refactor-compression.part-0
- compression refactor: undo
MaskRay added a comment.
I think this can be pushed now. You need to remove the variable
> In file included from
> /var/lib/buildkite-agent/builds/llvm-project/llvm/lib/MC/ELFObjectWriter.cpp:41:
> /var/lib/buildkite-agent/builds/llvm-project/llvm/include/llvm/Support/Compression.h:27:30:
> err
ckissane added inline comments.
Comment at: llvm/include/llvm/Support/Compression.h:27
+static constexpr std::string AlgorithmName = "zlib";
static constexpr int NoCompression = 0;
MaskRay wrote:
> Is it still used?
>
> Prefer StringRef if the string is backe
MaskRay added inline comments.
Comment at: llvm/include/llvm/Support/Compression.h:27
+static constexpr std::string AlgorithmName = "zlib";
static constexpr int NoCompression = 0;
Is it still used?
Prefer StringRef if the string is backed from some storage.
MaskRay accepted this revision.
MaskRay added inline comments.
Comment at: llvm/unittests/Support/CompressionTest.cpp:21
using namespace llvm;
+using namespace llvm::compression;
Delete blank line between two `using`
CHANGES SINCE LAST ACTION
https://revie
phosek accepted this revision.
phosek added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128953/new/
https://reviews.llvm.org/D128953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
ckissane marked 2 inline comments as done.
ckissane added a comment.
comments addressed
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128953/new/
https://reviews.llvm.org/D128953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
ckissane updated this revision to Diff 441763.
ckissane edited the summary of this revision.
ckissane added a comment.
remove compression namespace alias work
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128953/new/
https://reviews.llvm.org/D128953
Files:
clang-tools-extra/clangd/in
ckissane updated this revision to Diff 441757.
ckissane added a comment.
discard debug string changes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128953/new/
https://reviews.llvm.org/D128953
Files:
clang-tools-extra/clangd/index/Serialization.cpp
clang-tools-extra/clangd/unittest
MaskRay accepted this revision.
MaskRay added a comment.
LGTM. Happy when @phosek is happy
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128953/new/
https://reviews.llvm.org/D128953
___
cfe-commits maili
ckissane added inline comments.
Comment at: llvm/lib/ProfileData/InstrProf.cpp:154
+OS << ("profile uses " + compression::profile::AlgorithmName +
+ " compression but the profile reader was built " + "without " +
+ compression::profile::AlgorithmName + " s
ckissane added inline comments.
Comment at: llvm/include/llvm/Support/Compression.h:49-51
+namespace profile = llvm::compression::zlib;
+
+namespace serialize = llvm::compression::zlib;
phosek wrote:
> I think we will need to support dynamically selecting (de)com
15 matches
Mail list logo
