[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D128844: Improve the formatting of static_assert messages

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda1609ad7354: Improve the formatting of static_assert messages (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D128844: Improve the formatting of static_assert messages

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM. (The clang-format if more of a suggestion than anything else currently) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https:

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin added a comment. @philnik There seems to be an unrelated clang-format issue but otherwise the build looks fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 __

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin updated this revision to Diff 441448. cor3ntin added a comment. Missing -re in a few places Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D128844: Improve the formatting of static_assert messages

Mordante accepted this revision. Mordante added a comment. In D128844#360 , @aaron.ballman wrote: > So I *think* this LG, but am not certain what will happen when you land it. I > think the precommit CI failures are not failures that will happen whe

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin updated this revision to Diff 441439. cor3ntin added a comment. Pushing for CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D128844: Improve the formatting of static_assert messages

philnik requested changes to this revision. philnik added a comment. This revision now requires changes to proceed. Sorry I missed that. You have to changes the libc++ tests to regex checks to allow both error-styles. This can then be removed once we drop support for LLVM 14 (so after the releas

[PATCH] D128844: Improve the formatting of static_assert messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I agree with the changes in principle, but it looks like the libc++ precommit CI builder is failing with a bunch of failures... but those failures look like the precommit CI isn'

[PATCH] D128844: Improve the formatting of static_assert messages

philnik accepted this revision. philnik added 1 blocking reviewer(s): aaron.ballman. philnik added a comment. LGTM from the libc++ side of things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128844/new/ https://reviews.llvm.org/D128844 _

[PATCH] D128844: Improve the formatting of static_assert messages

cor3ntin created this revision. Herald added a subscriber: wenlei. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Display 'static_assert failed: m