This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc6c1f181b8a: [clangd][ObjC] Fix ObjC method definition
completion (authored by dgoldman).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
dgoldman updated this revision to Diff 441685.
dgoldman added a comment.
- Use codeCompletionString(Result) for RK_Pattern
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128821/new/
https://reviews.llvm.org/D128821
Files:
clang-tools-extra/clangd
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:866
case CodeCompletionResult::RK_Pattern:
- return Result.Pattern->getTypedText();
+ CCS = Result.Pattern;
+ break;
sammccall wrote:
> weirdly, codeCompleti
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Ah, this is subtle. Thanks!
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:866
case CodeCompletionResult::RK_Pattern:
- return Result.Pattern->getTyped
dgoldman created this revision.
dgoldman added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-
