[PATCH] D128805: [pseudo] Fix bugs/inconsistencies in forest dump.

2022-06-29 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGbc5e7ced1c7e: [pseudo] Fix bugs/inconsistencies in forest dump. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D128805?vs=440939&i

[PATCH] D128805: [pseudo] Fix bugs/inconsistencies in forest dump.

2022-06-29 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/unittests/ForestTest.cpp:138 + + const auto *B = &Arena.createSequence(symbol("B"), ruleFor("B"), {Star}); + const auto *A1 = &Arena.createSequence(symbol("A"), rul

[PATCH] D128805: [pseudo] Fix bugs/inconsistencies in forest dump.

2022-06-29 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/unittests/ForestTest.cpp:138 + + const auto *B = &Arena.createSequence(symbol("B"), ruleFor("B"), {Star}); + const auto *A1 = &Aren

[PATCH] D128805: [pseudo] Fix bugs/inconsistencies in forest dump.

2022-06-29 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. - when printing a shared node for the second time, don't pr