[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

2022-08-09 Thread Frederic Cambus via Phabricator via cfe-commits
fcambus added a comment. Agreed, that makes sense. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128757/new/ https://reviews.llvm.org/D128757 ___ cfe-commits mailing list cfe-commits

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

2022-07-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Windows is very different from all other OSes. Having a fuse-ld-windows.c may be fine. Again, NetBSD shares many characteristics with other OSes and having a test for all ~10 ELF OSes Clang supports seems too much. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

2022-07-03 Thread Frederic Cambus via Phabricator via cfe-commits
fcambus added a comment. In D128757#3616795 , @MaskRay wrote: > I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, > especially for an ELF OS like NetBSD which shares many characteristics with > other ELF OSes. It will be over

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

2022-06-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, especially for an ELF OS like NetBSD which shares many characteristics with other ELF OSes. It will be overwhelming. The option may be better added in a netbsd specific file. Repository: rG

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

2022-06-28 Thread Frederic Cambus via Phabricator via cfe-commits
fcambus created this revision. fcambus added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://rev