[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-29 Thread Joseph Huber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG56ab966a04dd: [CUDA] Stop adding CUDA features twice (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128752/new/ https://reviews.llvm.o

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-28 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D128752#3616837 , @jhuber6 wrote: > In D128752#3616831 , @tra wrote: > >> Do we have tests that verify `-target-feature` arguments? It may be worth >> adding a test case there checking for

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-28 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D128752#3616831 , @tra wrote: > Do we have tests that verify `-target-feature` arguments? It may be worth > adding a test case there checking for redundant features. Yeah, we have some existing tests that check for including

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-28 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Do we have tests that verify `-target-feature` arguments? It may be worth adding a test case there checking for redundant features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-28 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D128752#3616675 , @tra wrote: > We already heard complaints that searching for CUDA installation in multiple > places does add a measurable delay when the search hits NFS-mounted > directories. > > Replacing uses of `CudaInst

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-28 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D128752#3616579 , @jhuber6 wrote: > In D128752#3616553 , @tra wrote: > >>> we no longer will have a cached CUDA installation so we will usually create >>> it twice. >> >> Does that result

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-28 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D128752#3616553 , @tra wrote: >> we no longer will have a cached CUDA installation so we will usually create >> it twice. > > Does that result in extra output in case we find an unexpected CUDA version, > or when compiler is

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-28 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. > we no longer will have a cached CUDA installation so we will usually create > it twice. Does that result in extra output in case we find an unexpected CUDA version, or when compiler is run with `-v` ? We may want to wrap installation detector creation into some sort of s

[PATCH] D128752: [CUDA] Stop adding CUDA features twice

2022-06-28 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We currently call t