[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

2022-07-08 Thread Aaron Ballman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfee77a20732c: Disable clang-format entirely for test directories (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

2022-07-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 442298. aaron.ballman added a comment. Herald added projects: LLVM, clang-tools-extra. Herald added a subscriber: llvm-commits. Rebased and made the same changes for the LLVM and clang-tools-extra tests. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

2022-07-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman commandeered this revision. aaron.ballman edited reviewers, added: mboehme; removed: aaron.ballman. aaron.ballman added a comment. At the off-list request of @mboehme, I'm commandeering this review to take it over the finish line whenever the RFC finishes. Repository: rG LLVM Gi

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

2022-06-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Should we also do `llvm/test` and `clang-tools-extra/test` at the same time? The LLVM tests will show up in precommit CI, but I'm not certain that precommit CI actually tests clang-tools-extra (it also notably lacks coverage for libc++ and lldb as well). Reposit

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

2022-06-28 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added a comment. In D128706#3615623 , @aaron.ballman wrote: > The changes here LGTM and I think this is the correct way to go. However, > since you discovered that it was perhaps intentional that we did some style > checking on tests, do you th

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

2022-06-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. The changes here LGTM and I think this is the correct way to go. However, since you discovered that it was perhaps intentional that we did some style checking on tests, do you think we should have a brief community RFC just to make sure everyone's on the same page

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

2022-06-28 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. Herald added a subscriber: JDevlieghere. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See discussion here: https://github.com/llvm/llvm-project/issues/55982 We don't g