This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfe66aebd7551: [pseudo] Define a clangPseudoCLI library.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D128679?vs=440929&
sammccall accepted this revision.
sammccall added a comment.
Looks good!
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Language.h:21
+ Grammar G;
+ LRTable Table;
+
LR might be more distinguishing (and shorter!), up to you
Repository:
rG LLVM
hokein added inline comments.
Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:51
const std::string *SourceText = nullptr;
-const Grammar *G = nullptr;
+const Language *PLang = nullptr;
sammccall wrote:
> nit: still PLang here and in a bunch of pl
hokein updated this revision to Diff 440929.
hokein marked an inline comment as done.
hokein added a comment.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128679/new/
https://reviews.llvm.org/D128679
Files:
clang-tools-e
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:51
const std::string *SourceText = nullptr;
-const Grammar *G = nullptr;
+const Language *PLang = nul
hokein added inline comments.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:115
// Parameters for the GLR parsing.
+// FIXME: refine it with the ParseLang struct.
struct ParseParams {
sammccall wrote:
> You're already touching the callsites of
hokein updated this revision to Diff 440765.
hokein marked an inline comment as done.
hokein added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128679/new/
https://reviews.llvm.org/D128679
Files:
clang-tools-extra/ps
sammccall added a comment.
Thanks, the split here looks good!
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:115
// Parameters for the GLR parsing.
+// FIXME: refine it with the ParseLang struct.
struct ParseParams {
You're already touching t
hokein updated this revision to Diff 440366.
hokein added a comment.
remove a dependency from pseudoCLI lib
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128679/new/
https://reviews.llvm.org/D128679
Files:
clang-tools-extra/pseudo/benchmarks/Ben
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a subscriber: mgorny.
Herald added a project: All.
hokein requested review of this revision.
Herald added a subscriber: alextsao1999.
Herald added a project: clang-tools-extra.
- define a common data structure ParseLang
10 matches
Mail list logo