dgoldman updated this revision to Diff 479659.
dgoldman marked 4 inline comments as done.
dgoldman added a comment.
Fixes for review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128677/new/
https://reviews.llvm.org/D128677
Files:
clang-tools-ex
kadircet added a comment.
we should have tests in `clang/unittests/Tooling/HeaderIncludesTest.cpp` and
the commit itself should be tagged as `[clang][Tooling]` rather than `[clangd]`.
Comment at: clang-tools-extra/clangd/Headers.h:250
+ llvm::Optional insert(llvm::StringRef V
