[PATCH] D128672: Update DynInit generation for ASan globals.

2022-07-11 Thread Mitch Phillips via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf18de7619e5d: Update DynInit generation for ASan globals. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/ https://reviews.llv

[PATCH] D128672: Update DynInit generation for ASan globals.

2022-07-11 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 443702. hctim marked an inline comment as done. hctim added a comment. Integrate Vitaly's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/ https://reviews.llvm.org/D128672 Files: clang/lib

[PATCH] D128672: Update DynInit generation for ASan globals.

2022-07-11 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-68 - if (FsanitizeArgument.has(SanitizerKind::Address)) { -// TODO(hctim): Make this conditional whe

[PATCH] D128672: Update DynInit generation for ASan globals.

2022-06-27 Thread Mitch Phillips via Phabricator via cfe-commits
hctim created this revision. hctim added a reviewer: vitalybuka. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address a follow-up TODO for Sanitizer Metadata. Repository: rG LLVM Github Monorepo ht