[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei added a comment. In D128653#3633704 , @lenary wrote: > You likely need `// REQUIRES: powerpc-registered-target` in the top of the > test, as `-enable-ppc-gen-scalar-mass` is only present if the PowerPC target > has been compiled into LLVM.

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

lenary added a comment. You likely need `// REQUIRES: powerpc-registered-target` in the top of the test, as `-enable-ppc-gen-scalar-mass` is only present if the PowerPC target has been compiled into LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei added a comment. Just took it down temporarily. -- Looking at it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 ___ cfe-commits mailing list cf

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

dyung added a comment. Hi @masoud.ataei, the test you added in this commit is failing on the PS4 bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/24469 clang (LLVM option parsing): Unknown command line argument '-enable-ppc-gen-scalar-mass'. Try: 'clang (LLVM op

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour accepted this revision. bmahjour added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 __

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 441170. masoud.ataei added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c llvm/

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour added inline comments. Comment at: clang/test/CodeGen/lower-mass-end-to-end.c:33 +// CHECK-MASS-AFN: __xl_sin +// CHECK-NO-MASS-FAST-NOT: __xl_sin{{_finite}} +// CHECK-NO-MASS-AFN-NOT: __xl_sin{{_finite}} I don't think this works the way you expect it:

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 440625. masoud.ataei added a comment. Test updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c llvm/li

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour added inline comments. Comment at: clang/test/CodeGen/lower-mass-end-to-end.c:33-34 +// CHECK-MASS-AFN: __xl_sin +// CHECK-NOMASS-FAST-NOT: __xl_sin_finite +// CHECK-NOMASS-AFN-NOT: __xl_sin +// CHECK: blr Please also check for CHECK-NOMASS-FAST-NOT: __

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei updated this revision to Diff 440334. masoud.ataei added a comment. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128653/new/ https://reviews.llvm.org/D128653 Files: clang/test/CodeGen/lower-mass-end-to-end.c llvm/

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour added a comment. The description should explain why this change is necessary. Comment at: clang/test/CodeGen/lower-mass-end-to-end.c:1 +// RUN: %clang -mllvm -enable-ppc-gen-scalar-mass -O3 -fapprox-func --target=powerpc64le-unknown-linux-gnu -S %s -o -| FileCheck %s

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

masoud.ataei created this revision. masoud.ataei added reviewers: bmahjour, renenkel, rzurob, w2yehia. masoud.ataei added a project: PowerPC. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Herald added a project: All. masoud.ataei requested review of this revision. Herald added pr