pscoro updated this revision to Diff 442682.
pscoro added a comment.
patch fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128652/new/
https://reviews.llvm.org/D128652
Files:
clang/include/clang/Basic/BuiltinsPPC.def
clang/lib/Basic/Targets/
shchenz added a comment.
Please make sure the patch is able to compile first. I fixed two build
failures, it still fails : (
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:221
+ def int_ppc_kill_canary
+ : GCCBuiltin<"__builtin_ppc_kill_canary">,
+Intrins
lkail added a comment.
Summary should be updated as @nemanjai has said.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128652/new/
https://reviews.llvm.org/D128652
___
cfe-commits mailing list
cfe-commits
pscoro updated this revision to Diff 441374.
pscoro added a comment.
fixed XOR usage, added linux tests and other small fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128652/new/
https://reviews.llvm.org/D128652
Files:
clang/include/clang/B
nemanjai added a comment.
"Made a new phabricator review because of git issues" is not an appropriate
description of a review/revision.
Hopefully the description you add will describe what this intrinsic is supposed
to do. It seems to me that this is a poorly designed feature if it is meant to
pscoro created this revision.
Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai.
Herald added a project: All.
pscoro requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Repository:
rG LLVM Github Monorepo
http