Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

2015-09-14 Thread Piotr Padlewski via cfe-commits
Prazek closed this revision. Prazek added a comment. Assume loads released. http://reviews.llvm.org/D12865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

2015-09-14 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:394-406 @@ +393,15 @@ + +for (const auto &VtableComponent : VtableLayout.vtable_components()) { + if (VtableComponent.isRTTIKind()) { +const CXXRecordDecl *RTTIDecl = VtableComponent.getRTTIDe

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

2015-09-14 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 34761. Prazek marked 3 inline comments as done. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-assume-load.cpp test/CodeGenCXX/vtable-available-exte

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

2015-09-14 Thread David Majnemer via cfe-commits
majnemer added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:394-406 @@ +393,15 @@ + +for (const auto &VtableComponent : VtableLayout.vtable_components()) { + if (VtableComponent.isRTTIKind()) { +const CXXRecordDecl *RTTIDecl = VtableComponent.getRTTI

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

2015-09-14 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/CodeGen/ItaniumCXXABI.cpp:399-400 @@ +398,4 @@ + return true; + } + else if (VtableComponent.isUsedFunctionPointerKind()) { +co

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

2015-09-14 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 34750. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-assume-load.cpp test/CodeGenCXX/vtable-available-externally.cpp Index: test/CodeGenCXX/vtable

[PATCH] D12865: Generating available_externally vtables and assume loads bugfix

2015-09-14 Thread Piotr Padlewski via cfe-commits
Prazek created this revision. Prazek added reviewers: rsmith, rjmccall, hans, majnemer. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-assume-load.