[PATCH] D128569: Start support for HLSL `RWBuffer`

uabelho added a comment. Hello, Compiling with gcc I get the following warning with this patch: [1832/2330] Building CXX object tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/HLSLExternalSemaSource.cpp.o In file included from ../../clang/include/clang/Sema/ExternalSemaSource.h:15,

[PATCH] D128569: Start support for HLSL `RWBuffer`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e56d0dbe3c8: Start support for HLSL `RWBuffer` (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D128569?vs=442690&id=448326

[PATCH] D128569: Start support for HLSL `RWBuffer`

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Fairly straightforward. LGTM with a couple of nits Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:48 + + // Complete an incomplete HLSL builtin type + void C

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz updated this revision to Diff 442690. beanz added a comment. Updating with some minor tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128569/new/ https://reviews.llvm.org/D128569 Files: clang/include/clang/Sema/HLSLExternalSemaSource

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz updated this revision to Diff 440778. beanz added a comment. Updating based on PR feedback and removing the new builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128569/new/ https://reviews.llvm.org/D128569 Files: clang/include/clang

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1703 LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_pointer, "v*", "i", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_status, "Ui", "i", HLSL_

[PATCH] D128569: Start support for HLSL `RWBuffer`

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1703 LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_pointer, "v*", "i", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_status, "Ui", "i",

[PATCH] D128569: Start support for HLSL `RWBuffer`

beanz created this revision. beanz added reviewers: Anastasia, spyffe, kuhar, bogner, python3kgae. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Most of the change here is fleshing out the HLSLExternalSemaSource with builder implementations to