[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

miyuki added a comment. Thanks for fixing the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86866107b89c: [Clang] Fix: Restore warning inadvertently removed by D126061. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme updated this revision to Diff 440494. mboehme marked 2 inline comments as done. mboehme added a comment. Remove trailing spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 Files: clang/inclu

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/test/SemaCXX/attr-declspec-ignored.cpp:3-6 +// For this test, we want the contents of the namespaces to be indented, which +// clang-format doesn't like. Also, clang-format reformats the lo

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme updated this revision to Diff 440492. mboehme added a comment. Remove `clang-format` directives from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 Files: clang/include/clang/Sema/Sema.h

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit in the testing. Comment at: clang/lib/Sema/SemaDecl.cpp:4633-4637 Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, De

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme updated this revision to Diff 440134. mboehme marked an inline comment as done. mboehme added a comment. Turn off clang-format for attr-declspec-ignored.cpp. It has existing formatting (indentation within namespaces) that's incompatible with clang-format. Repository: rG LLVM Github Mo

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:4633-4637 Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, DeclSpec &DS, RecordDecl *&AnonRecord) { - return ParsedFr

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme updated this revision to Diff 439708. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 Files: clang/include/clang/Sema/Sema.h cl

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

aaron.ballman added a comment. Thank you for the quick fix! I had a question about why only one of the two interfaces needed to be updated and whether we thought that was sensible, but otherwise the changes here look correct to me. Comment at: clang/lib/Sema/SemaDecl.cpp:4633

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before D126061 , Clang would warn about this code struct X { [[deprecated]] stru