[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 00. ckissane added a comment. tidy some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cmake/config-ix.cmake llvm/cma

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. The patch looks mostly good but please fix the subject and the summary. Note: if you fix the local commit message, you can use ` arc diff --head=HEAD 'HEAD^' --verbatim` to update the subject and the summary. Comment at: llvm/lib/Support/Compression.c

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 444374. ckissane added a comment. - Trim CMAKE modifications to minimum needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cm

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3646601 , @MaskRay wrote: > In D128465#3646561 , @ckissane > wrote: > >> In D128465#3646258 , @MaskRay >> wrote: >> >>> In D128465#3

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. In D128465#3646561 , @ckissane wrote: > In D128465#3646258 , @MaskRay wrote: > >> In D128465#3646203 , @ckissane >> wrote: >> >>> In D128465#3642

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3646258 , @MaskRay wrote: > In D128465#3646203 , @ckissane > wrote: > >> In D128465#3642997 , @MaskRay >> wrote: >> >>> As I mention

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 444078. ckissane added a comment. - add zstd tests to CompressionTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeList

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. In D128465#3646203 , @ckissane wrote: > In D128465#3642997 , @MaskRay wrote: > >> As I mentioned, the proper approach is to add zstd functionality along with >> the CMake change, instead

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3642997 , @MaskRay wrote: > As I mentioned, the proper approach is to add zstd functionality along with > the CMake change, instead of adding CMake to all llvm-project components > without a way to test them. @MaskR

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 444044. ckissane added a comment. - make sure LLVM_ENABLE_ZSTD OFF turns into 0 - add zstd compression namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 File

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added a comment. As I mentioned, the proper approach is to add zstd functionality along with the CMake change, instead of adding CMake to all llvm-project components without a way to test them. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABL

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > MaskRay wrote: > > This needs a change in lld/test/C

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443687. ckissane added a comment. clean a space and make accurate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay reopened this revision. MaskRay added a comment. This revision is now accepted and ready to land. This patch has changed a lot from what I have reviewed. The CMake change should be added along with `llvm::compression::zstd::*` functions. Otherwise the change just introduces some CMake var

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > This needs a change in lld/test/CMakeLists.txt > > L

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ This needs a change in lld/test/CMakeLists.txt Looks like you haven't

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ldionne added inline comments. Comment at: llvm/CMakeLists.txt:441 +set(LLVM_ENABLE_ZSTD "ON" CACHE STRING "Use zstd for compression/decompression if available. Can be ON, OFF, or FORCE_ON") + This broke builds that do not specify `LLVM_ENABLE_ZSTD=OFF` explic

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf07caf20b9d3: [llvm] cmake config groundwork to have ZSTD in LLVM (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443310. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files:

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. marked fixed comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commi

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443308. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake - added have_zstd to compiler-rt/test/lit.common.cfg.py, clang-tools-extra/clangd/test/lit.cfg.py and several lit.site.cfg.py.in files Repository:

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

phosek added inline comments. Comment at: llvm/cmake/modules/FindZSTD.cmake:1 +# Copyright (c) Meta Platforms, Inc. and affiliates. +# MaskRay wrote: > How did you derive this? > > The file seems contributed by you (I don't think facebook/zstd has such a > file

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added a comment. Consider adding `have_zstd` to `compiler-rt/test/lit.common.cfg.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits mai

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay accepted this revision. MaskRay added a comment. Please check both `LLVM_ENABLE_ZSTD={on,off}` work. Ideally, check that when zstd' cmake (`libzstd-dev` on Debian) is unavailable, `LLVM_ENABLE_ZSTD=on` works (there is no zstd functionality but the cmake invocation should succeed). ===

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM although I think I'd be more comfortable with Petr's +2 for cmake changes. Would it be better instead to expose `LLVM_ENABLE_ZSTD` to subrepos like clangd or flang until they're

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. mark outdated comments done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits