[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-05 Thread Sam Elliott via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1666f09933ee: [ARM] Add Support for Cortex-M85 (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-05 Thread Thorsten via Phabricator via cfe-commits
tschuett accepted this revision. tschuett added a comment. LGTM. Please update the summary before you commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415 _

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-05 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. @tschuett I've corrected the patch based on your feedback. If you're happy, I'm going to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415 ___

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-04 Thread Sam Elliott via Phabricator via cfe-commits
lenary updated this revision to Diff 442109. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415 Files: clang/docs/ReleaseNotes.rst clang/test/CodeGen/arm-target-features.c clang/test/Driver/arm-cortex-cp

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-04 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. In D128415#3628274 , @tschuett wrote: > The Clang release notes indicate that PACBTI is off by default. In several > places, I can see PACBTI. Is the `ARM.td` missing something? Nope, I should have re-checked the whole patch. Upd

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-04 Thread Dave Green via Phabricator via cfe-commits
dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Other than the release note change it might be worth adding some tests for -mcpu=cortex-m85+nopacbti and related configurations. Otherwise LGTM Comment at: clang/docs/Rel

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-04 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. The Clang release notes indicate that PACBTI is off by default. In several places, I can see PACBTI. Is the `ARM.td` missing something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D1

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-04 Thread Sam Elliott via Phabricator via cfe-commits
lenary marked an inline comment as done. lenary added a comment. The other changes in this commit are to enable PACBTI by default, as agreed with stakeholders within Arm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.ll

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-07-04 Thread Sam Elliott via Phabricator via cfe-commits
lenary updated this revision to Diff 442079. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415 Files: clang/docs/ReleaseNotes.rst clang/test/CodeGen/arm-target-features.c clang/test/Driver/arm-cortex-cp

[PATCH] D128415: [ARM] Add Support for Cortex-M85

2022-06-23 Thread Dave Green via Phabricator via cfe-commits
dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARM.td:1443 +def : ProcessorModel<"cortex-m85", CortexM4Model, [ARMv81mMainline, + FeatureDSP, Please use the CortexM7 schedule - it is

[PATCH] D128415: [ARM] Add Support for Cortex-M85 r=MarkMurrayARM,dmgreen,tmatheson

2022-06-23 Thread Sam Elliott via Phabricator via cfe-commits
lenary created this revision. lenary added reviewers: MarkMurrayARM, dmgreen, tmatheson. Herald added subscribers: jdoerfert, hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,