[PATCH] D128411: [syntax] Introduce a TokenManager interface.

hokein added a comment. In D128411#3654452 , @DavidSpickett wrote: > FYI, after this change I get: > > > /home/david.spickett/llvm-project/clang/include/clang/Tooling/Syntax/TokenBufferTokenManager.h:20:7: > warning: 'clang::syntax::TokenBufferTokenM

[PATCH] D128411: [syntax] Introduce a TokenManager interface.

DavidSpickett added a comment. FYI, after this change I get: /home/david.spickett/llvm-project/clang/include/clang/Tooling/Syntax/TokenBufferTokenManager.h:20:7: warning: 'clang::syntax::TokenBufferTokenManager' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor] class To

[PATCH] D128411: [syntax] Introduce a TokenManager interface.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG263dcf452fa0: [syntax] Introduce a TokenManager interface. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128411: [syntax] Introduce a TokenManager interface.

hokein updated this revision to Diff 444244. hokein added a comment. Herald added subscribers: kadircet, arphaman. Herald added a project: clang-tools-extra. update the API changes in clangd part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128411