This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcafb8b4ff2c3: [clang][dataflow] Use diagnosis API in
optional checker (authored by samestep).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
samestep updated this revision to Diff 441117.
samestep added a comment.
- Merge branch 'diagnose-api' into optional-check-diagnose
- Update using review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128352/new/
https://reviews.llvm.org/D1
samestep marked an inline comment as done.
samestep added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:126-129
+auto *Lattice =
+llvm::any_cast(&State.Lattice.Value);
+PostVisitStmt(Stmt, DataflowAnalysisS
sgatev accepted this revision.
sgatev added inline comments.
Comment at:
clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:126-129
+auto *Lattice =
+llvm::any_cast(&State.Lattice.Value);
+PostVisitStmt(Stmt, DataflowAnalysisState{
+
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:67
+std::move(StmtDiagnostics.begin(), StmtDiagnostics.end(),
+ std::back_inserter(Diagnostics
ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.
Nice!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128352/new/
https://reviews.llvm.org/D128352
samestep updated this revision to Diff 440702.
samestep added a comment.
Herald added a project: clang.
- Merge branch 'diagnose-api' into optional-check-diagnose
- Use the updated API
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128352/new/
https
samestep updated this revision to Diff 439413.
samestep added a comment.
- Merge branch 'diagnose-api' into optional-check-diagnose
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128352/new/
https://reviews.llvm.org/D128352
Files:
clang-tools-ext
samestep updated this revision to Diff 439373.
samestep added a comment.
- Merge branch 'diagnose-api' into optional-check-diagnose
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128352/new/
https://reviews.llvm.org/D128352
Files:
clang-tools-ext
samestep updated this revision to Diff 439052.
samestep added a comment.
- Merge branch 'diagnose-api' into optional-check-diagnose
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128352/new/
https://reviews.llvm.org/D128352
Files:
clang-tools-ext
samestep added inline comments.
Comment at:
clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:58
BlockToOutputState =
- dataflow::runDataflowAnalysis(*Context, Analysis, Env);
+ dataflow::runTypeErasedDataflowAnalysis(*Context, Analy
sgatev added inline comments.
Comment at:
clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:58
BlockToOutputState =
- dataflow::runDataflowAnalysis(*Context, Analysis, Env);
+ dataflow::runTypeErasedDataflowAnalysis(*Context, Analysi
samestep updated this revision to Diff 439042.
samestep added a comment.
Remove unnecessary ExitBlock code
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128352/new/
https://reviews.llvm.org/D128352
Files:
clang-tools-extra/clang-tidy/bugprone/Un
samestep created this revision.
Herald added subscribers: martong, tschuett, carlosgalvezp, xazax.hun.
Herald added a project: All.
samestep requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
14 matches
Mail list logo
