[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

2022-06-29 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc09e53337413: [clangd] Also mark output arguments of operator call expressions (authored by ckandeler, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

2022-06-29 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. In D128329#3617172 , @nridge wrote: > I'm going to take the liberty of approving this, as it seems straightforward > and unlikely to be contentious in any way. Thanks! > Please let me know if you need me to commit it. Yes, p

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

2022-06-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! I'm going to take the liberty of approving this, as it seems straightforward and unlikely to be contentious in any way. Please let me know if you need me to commit it. Repository:

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

2022-06-28 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler updated this revision to Diff 440650. ckandeler marked 2 inline comments as done. ckandeler added a comment. Improvements as per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128329/new/ https://reviews.llvm.org/D128329

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

2022-06-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Thanks for the patch! nit: please make the commit message a bit more specific, e.g. "Also apply the 'mutable' semantic token modifier to arguments of overloaded call operators" Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:540 //

[PATCH] D128329: [clangd] Also mark output arguments of operator call expressions

2022-06-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. There's no reason that argum