rnk added a comment.
Looks like this got committed. Sorry for the delay, I was travelling.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ikudrin updated this revision to Diff 35585.
ikudrin added a comment.
- Rebased to the top of history
- Made pathes local to clang subtree
http://reviews.llvm.org/D12832
Files:
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolChains.h
Index: lib/Driver/ToolChains.h
=
ikudrin added a comment.
Ping...
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ikudrin added a comment.
Please, can someone commit the changes as I don't have write permissions?
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ikudrin marked an inline comment as done.
ikudrin added a comment.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ikudrin updated this revision to Diff 35013.
ikudrin added a comment.
Skip directories like C:\Program Files (x86)\Windows Kits\10\Include\wdf, which
come from WDK installation, when looking for SDK version. Now, we detect
directories even better than vsvars32.bat in that situation.
http://rev
ikudrin added a comment.
I found a new problem, after install WDK. I'll submit a new version in a moment.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks like I forgot to submit the comments I wrote. Anyway, looks good.
Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:238
@@ +237,3 @@
+ continue;
+const StringRef Can
ikudrin marked 2 inline comments as done.
ikudrin added a comment.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
