[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

2022-06-23 Thread Paulo Matos via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fdfeb0847df: [WebAssembly] Update test to run it in opaque pointers mode (authored by pmatos). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

2022-06-23 Thread Paulo Matos via Phabricator via cfe-commits
pmatos updated this revision to Diff 439345. pmatos added a comment. Remove extraneous whitespace. Make equal CHECK lines use WEBASSEMBLY: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128282/new/ https://reviews.llvm.org/D128282 Files: clang/te

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

2022-06-22 Thread Thomas Lively via Phabricator via cfe-commits
tlively added a comment. In D128282#3601100 , @asb wrote: > In D128282#3600355 , @tlively wrote: > >> I think the lines still differ in that one tests wasm32 and the other tests >> wasm64 (the triples are differe

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

2022-06-22 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. In D128282#3600355 , @tlively wrote: > I think the lines still differ in that one tests wasm32 and the other tests > wasm64 (the triples are different). Yeah, but the convention used elsewhere in this test file is to use `WEBASSEMB

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

2022-06-21 Thread Thomas Lively via Phabricator via cfe-commits
tlively accepted this revision. tlively added a comment. I think the lines still differ in that one tests wasm32 and the other tests wasm64 (the triples are different). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128282/new/ https://reviews.llvm

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

2022-06-21 Thread Alex Bradbury via Phabricator via cfe-commits
asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Though it also looks like all the WEBASSEMBLY32/WEBASSEMBLY64 lines you're modifying match each other, so could be combined to single `WEBASSEMBLY:` lines. It might be worth doing that while y

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

2022-06-21 Thread Paulo Matos via Phabricator via cfe-commits
pmatos created this revision. pmatos added reviewers: asb, tlively. Herald added subscribers: StephenFan, wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. pmatos requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald adde