[PATCH] D128249: Adding clone_attrs attribute.

2022-06-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D128249#3599551 , @plotfi wrote: > Thanks for the feedback on corner cases @aaron.ballman, this will give me > more concrete things to think about here. > > At the moment I mainly thinking about a case: > > typedef int

[PATCH] D128249: Adding clone_attrs attribute.

2022-06-21 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. Thanks for the feedback on corner cases @aaron.ballman, this will give me more concrete things to think about here. At the moment I mainly thinking about a case: typedef int foo; enum : foo {} __attribute__((__clone_attrs_from__(foo))); This is mostly because of how

[PATCH] D128249: Adding clone_attrs attribute.

2022-06-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Can you add some details to the patch summary as to what problem you're trying to solve with these changes? The idea itself has some interesting edge cases to think about: [[some_attr]] void decl(); [[clone_attrs_from(decl)]] void other(); [[some_new_attr]]

[PATCH] D128249: Adding clone_attrs attribute.

2022-06-21 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. This is pretty incomplete. Please ignore for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128249/new/ https://reviews.llvm.org/D128249 ___ cfe-commits mailing list cfe-commi

[PATCH] D128249: Adding clone_attrs attribute.

2022-06-21 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi created this revision. plotfi added a reviewer: arphaman. Herald added a reviewer: aaron.ballman. Herald added a project: All. plotfi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just experimental for the time being. Posti