[PATCH] D128207: [clang-doc][NFC] Fix reference invalidation assertion failure.

2022-06-22 Thread liushuai wang via Phabricator via cfe-commits
MTC added a comment. Sorry for the delayed response. Adding the regression test is not as simple as I thought, **first of all clang-tools-extra does not enable the //assert//**, see https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/test/lit.site.cfg.py.in . And add the clang-doc

[PATCH] D128207: [clang-doc][NFC] Fix reference invalidation assertion failure.

2022-06-20 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Is there a test that can be added so this doesn’t regress? Also, I wonder if `assign` could/should add logic to be resilient to this. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128207/new/ https://reviews.llvm.org/D12

[PATCH] D128207: [clang-doc][NFC] Fix reference invalidation assertion failure.

2022-06-20 Thread liushuai wang via Phabricator via cfe-commits
MTC created this revision. MTC added reviewers: dexonsmith, mehdi_amini. MTC added a project: clang-tools-extra. Herald added subscribers: jsji, usaxena95, pengfei, kadircet, arphaman. Herald added a project: All. MTC requested review of this revision. Herald added subscribers: cfe-commits, ilya-bi