This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9f57b65a2728: [clangd] Include "final" when
printing class declaration (authored by tom-anders, committed by sammccall).
Repository:
rG LLVM Githu
tom-anders updated this revision to Diff 440676.
tom-anders added a comment.
Check for FinalAttr instead of using isEffectivelyFinal()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128202/new/
https://reviews.llvm.org/D128202
Files:
clang-tools-
sammccall added inline comments.
Comment at: clang/lib/AST/DeclPrinter.cpp:1010
+ if (D->isEffectivelyFinal()) {
+ Out << " final";
tom-anders wrote:
> sammccall wrote:
> > isEffectivelyFinal returns true for
> > `struct X { ~X() final; }`
> >
> > I don'
tom-anders added inline comments.
Comment at: clang/lib/AST/DeclPrinter.cpp:1010
+ if (D->isEffectivelyFinal()) {
+ Out << " final";
sammccall wrote:
> isEffectivelyFinal returns true for
> `struct X { ~X() final; }`
>
> I don't think we want to print `s
sammccall added inline comments.
Comment at: clang/lib/AST/DeclPrinter.cpp:1010
+ if (D->isEffectivelyFinal()) {
+ Out << " final";
isEffectivelyFinal returns true for
`struct X { ~X() final; }`
I don't think we want to print `struct X final {}` in that
tom-anders created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
tom-anders requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
Fixes https://github
