[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

phosek added a comment. In D128133#3724984 , @benshi001 wrote: > @phosek , > > I have re-landed my patch, it seems the core reason is compiler-rt is default > in Fuchsia environment, other than libgcc. > > please inform me if it went wrong any longer. T

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. @phosek , I have re-landed my patch, it seems the core reason is compiler-rt is default in Fuchsia environment, other than libgcc. please inform me if it went wrong any longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. In D128133#3723847 , @phosek wrote: > We started seeing test failures after this change on our bots. Would it be > possible to revert the change and address these issues before relanding? > > In `Clang :: Driver/avr-ld.c`: > >

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

phosek added a comment. We started seeing test failures after this change on our bots. Would it be possible to revert the change and address these issues before relanding? In `Clang :: Driver/avr-ld.c`: Script: -- : 'RUN: at line 1'; /b/s/w/ir/x/w/staging/llvm_build/bin/clang -### --ta

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44a647d21d94: [Driver] Support linking to compiler-rt for target AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:539 +// Link to compiler-rt. We directly put the libclang.builtins.a +// as input file, other than '-lclang.builtins'. +if (RtLib == ToolChain:

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

aykevl accepted this revision. aykevl added a comment. This revision is now accepted and ready to land. Looks good to me! Comment at: clang/lib/Driver/ToolChains/AVR.cpp:539 +// Link to compiler-rt. We directly put the libclang.builtins.a +// as input file, other than '

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. A gentle ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438238. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438195. benshi001 set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChain

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: StephenFan, Jim, dberris, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang.