This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG119a13199a91: [Driver] Pass -X to ld for riscv64-openbsd
(authored by brad).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
brad added inline comments.
Comment at: clang/test/Driver/openbsd.c:133
+// RUN: | FileCheck -check-prefix=CHECK-RISCV64-FLAGS %s
+// CHECK-RISCV64-FLAGS: "-X"
MaskRay wrote:
> It's useful to check other values like the `-m` emulation and the dynamic
> linker.
MaskRay added inline comments.
Comment at: clang/test/Driver/openbsd.c:133
+// RUN: | FileCheck -check-prefix=CHECK-RISCV64-FLAGS %s
+// CHECK-RISCV64-FLAGS: "-X"
It's useful to check other values like the `-m` emulation and the dynamic
linker.
Repository:
brad updated this revision to Diff 438075.
brad added a comment.
Fix the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128109/new/
https://reviews.llvm.org/D128109
Files:
clang/lib/Driver/ToolChains/OpenBSD.cpp
clang/test/Driver/openbsd.
brad updated this revision to Diff 438071.
brad added a comment.
Minus the new white space.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128109/new/
https://reviews.llvm.org/D128109
Files:
clang/lib/Driver/ToolChains/OpenBSD.cpp
clang/test/Dr
brad updated this revision to Diff 438070.
brad added a comment.
Add a test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128109/new/
https://reviews.llvm.org/D128109
Files:
clang/lib/Driver/ToolChains/OpenBSD.cpp
clang/test/Driver/openbsd.c
brad added a comment.
I will add a test.
Comment at: clang/lib/Driver/ToolChains/OpenBSD.cpp:159
+ if (ToolChain.getArch() == llvm::Triple::riscv64)
+CmdArgs.push_back("-X");
MaskRay wrote:
> isRISCV
>
> If OpenBSD gets riscv32, it'd need -X, too.
There
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Please add a test.
Comment at: clang/lib/Driver/ToolChains/OpenBSD.cpp:159
+ if (ToolChain.getArch() == llvm::Triple::riscv64)
+CmdArgs.push_back("-X");
brad created this revision.
brad added a reviewer: MaskRay.
brad added a project: clang.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr,
evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01,
shiva0217, kito-cheng, simoncook, krytarowski, arichardson.
H
