[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb1d908e5cf7: Adds AST matcher for ObjCStringLiteral (authored by t-rasmud). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud added a comment. In D128103#363 , @aaron.ballman wrote: > LGTM! Do you need me to commit on your behalf? If so, what name and email > address would you like me to use for patch attribution? Thank you @aaron.ballman. I believe I have the

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 441179. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/docs/LibASTMatchersReference.html clang/docs/ReleaseNotes.rs

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

aaron.ballman added a comment. The only things left to do are: regenerate the documentation by running clang/docs/tools/dump_ast_matchers.py and add a release note for the new matcher, but otherwise this looks good to me. In D128103#3617156 , @NoQ wrote

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

NoQ added a comment. Yes the use case is coming up in D126097 ; it's not used yet because `hasDescendant(StringLiteral)` is used to skip it but this matchert would be a more precise solution (yes there's an actual `StringLiteral` inside `ObjCStringLiteral`).

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440766. t-rasmud added a comment. Removes manually added documentation and adds it in the header file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/include/clang/ASTMatchers/ASTMatchers.

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. We typically don't add AST matchers until we have a need for them to be used in-tree (ASTMatchers.h is already really expensive to parse; adding matchers for everything possible with AST nodes would be prohibitively ex

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440450. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h clang/lib/ASTMatchers/ASTMatchersInternal.cpp cla

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

NoQ added a comment. Looks great, thanks! Comment at: clang/docs/LibASTMatchersReference.html:2041 + +Example matches "abcd" + NSString *s = @"abcd"; I think it's more appropriate for this documentation to mention the entire literal so that the reader didn't

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440443. t-rasmud added a comment. Documentation edits and other fixes, thanks to suggestions from @ziqingluo-90 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/docs/LibASTMatchersReference.

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440359. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/lib/ASTMatchers/ASTMatchersInternal.cpp clang/lib/ASTMatchers/Dynamic/Registry.cpp

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 438852. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang-tools-extra/unittests/clang-tidy/CMakeLists.txt clang-tools-extra/unittests/clang-tidy/ObjCStr

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

NoQ added a comment. Matcher tests are written as unittests in `unittests/ASTMatchers`, I don't think you need to make an entire new check for that hmmm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 _

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud created this revision. t-rasmud added reviewers: NoQ, usama54321. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. t-rasmud requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: