Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

2015-09-11 Thread Mike Spertus via cfe-commits
mspertus added a comment. Thanks, Aaron! Hal mentioned that I might need to ask you to commit on my behalf as I don't have commit access as of now. http://reviews.llvm.org/D12807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

2015-09-11 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r247442, thank you for the patch! http://reviews.llvm.org/D12807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

2015-09-11 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank for you this (I think it's going to help me out quite a bit)! http://r

[PATCH] D12807: Display name of identifier tokens in Visual Studio native visualizer

2015-09-11 Thread Mike Spertus via cfe-commits
mspertus created this revision. mspertus added a subscriber: cfe-commits. The Token visualizer in clang.natvis makes debugging Clang in Visual Studio much easier for keywords (because a given keyword is always the same), but it doesn't work very well for identifiers (because they are all differe