This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sgatev marked an inline comment as done.
Closed by commit rG83232099cb5e: [clang][dataflow] Extend flow condition in the
body of a for loop (authored by sgatev).
Repos
sgatev marked an inline comment as done.
sgatev added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:92
+ void VisitForStmt(const ForStmt *S) {
+auto *Cond = S->getCond();
xazax.hun wrote:
> Do we support `DoSt
sgatev updated this revision to Diff 438257.
sgatev added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128060/new/
https://reviews.llvm.org/D128060
Files:
clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.
xazax.hun accepted this revision.
xazax.hun added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:92
+ void VisitForStmt(const ForStmt *S) {
+auto *Cond = S->getCond();
Do we support `DoStmt` or is that missing?
sgatev updated this revision to Diff 437918.
sgatev added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128060/new/
https://reviews.llvm.org/D128060
Files:
clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.
ymandel accepted this revision.
ymandel added a comment.
Mild preference for splitting into three tests, since it technically different
code that's covered in each. But, up to you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128060/new/
https://
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3577-3580
+ASSERT_THAT(Results, ElementsAre(Pair("if_branch_1", _),
+
sgatev created this revision.
sgatev added reviewers: ymandel, xazax.hun, gribozavr2.
Herald added subscribers: martong, tschuett, rnkovacs.
Herald added a project: All.
sgatev requested review of this revision.
Herald added a project: clang.
Extend flow condition in the body of a for loop.
Repo
