This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdf90d22704d8: [CMake] Option to select C++ library for
runtimes that use it (authored by phosek).
Changed prior to commit:
https://reviews.llvm.or
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: compiler-rt/CMakeLists.txt:534
+if (COMPILER_RT_CXX_LIBRARY STREQUAL "libcxx")
+ # We are using the in-tree libc++ so avoid including the default one.
+
phosek added inline comments.
Comment at: compiler-rt/CMakeLists.txt:534
+if (COMPILER_RT_CXX_LIBRARY STREQUAL "libcxx")
+ # We are using the in-tree libc++ so avoid including the default one.
+ append_list_if(COMPILER_RT_HAS_NOSTDINCXX_FLAG -nostdinc++
COMPILER_RT_COMMON_CFLA
mstorsjo added inline comments.
Comment at: compiler-rt/CMakeLists.txt:534
+if (COMPILER_RT_CXX_LIBRARY STREQUAL "libcxx")
+ # We are using the in-tree libc++ so avoid including the default one.
+ append_list_if(COMPILER_RT_HAS_NOSTDINCXX_FLAG -nostdinc++
COMPILER_RT_COMMON_CF
phosek added a comment.
I'm aware of the duplication of logic for handling of `COMPILER_RT_CXX_LIBRARY`
and `SANITIZER_TEST_CXX_LIBNAME`. Right now my goal is to make the use of
in-tree libc++ in compiler-rt explicit, and then cleaning up the handling logic
in follow up changes.
Repository:
phosek created this revision.
phosek added reviewers: ldionne, smeenai, mstorsjo.
Herald added subscribers: Enna1, abrachet, mgorny.
Herald added a project: All.
phosek requested review of this revision.
Herald added projects: clang, Sanitizers.
Herald added subscribers: Sanitizers, cfe-commits.
W
