klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D12797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
angelgarcia updated this revision to Diff 34985.
angelgarcia added a comment.
Split a function and several other small changes.
http://reviews.llvm.org/D12797
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConvertCheck.h
test/clang-tidy/modernize-loop-convert-ba
angelgarcia marked 9 inline comments as done.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:494-495
@@ -493,4 +502,2 @@
} else {
- if (Descriptor.DerefByConstRef)
-AutoRefType = Context->getConstType(AutoRefType);
AutoRefType = Context->getLValueRe
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:419
@@ +418,3 @@
+ // assumption the user is trying to modernize their codebase.
+ if (getLangOpts().CPlusPlus) {
+Finder->addMatcher(makeArrayLoopMatcher(), this);
Now you c
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
Reorder the code in a more logical and understandable way.
http://reviews.llvm.org/D12797
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopCon
