[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG663e47a50f50: [OpenCL] Reduce emitting candidate notes for builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127961/new/ https://reviews.llvm.org/D127961 _

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

svenvh added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:11224 + // so do not generate such notes. + if (S.getLangOpts().OpenCL && Fn->isImplicit() && + Cand->FailureKind != ovl_fail_bad_conversion) Anastasia wrote: > It would have been ni

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:11224 + // so do not generate such notes. + if (S.getLangOpts().OpenCL && Fn->isImplicit() && + Cand->FailureKind != ovl_fail_bad_conversion) It would have been nice to print each

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. When overload resolution fails, clang