samestep updated this revision to Diff 438891.
samestep added a comment.
Only add the new API, don't change the check
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127898/new/
https://reviews.llvm.org/D127898
Files:
clang/docs/tools/clang-format
samestep added inline comments.
Comment at:
clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:66
+ SourceLocations Locs;
+ for (const CFGBlock *Block : Context->getCFG()) {
+// Skip blocks that were not evaluated.
xazax.hun wrote:
> Wh
xazax.hun added inline comments.
Comment at:
clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:66
+ SourceLocations Locs;
+ for (const CFGBlock *Block : Context->getCFG()) {
+// Skip blocks that were not evaluated.
While doing yet anot
tschuett added a comment.
C++ seems to be tied to templates. I wonder if super classes resp. inheritance
would make your life easier. You can explicitly define the API and
documentation. You could provide default implementations.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
ymandel added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:35
+using NoopDiags = std::tuple<>;
+
I'm not sure that this is valid style. It's essentially a unit type, which I
quite like, but I've never seen this don
samestep created this revision.
Herald added subscribers: martong, tschuett, carlosgalvezp, xazax.hun, mgorny.
Herald added a project: All.
samestep requested review of this revision.
Herald added projects: clang, LLVM, clang-tools-extra.
Herald added subscribers: cfe-commits, llvm-commits.
Reposi
