[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added a comment. In D127855#4048642 , @jyu2 wrote: > In D127855#3956014 , @sandeepkosuri > wrote: > >> As I do not have commit access, can someone commit this patch, now that it >> passes the pre-m

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added a comment. In D127855#4059776 , @jyu2 wrote: > Hi @sandeepkosuri, do you plan to fix this? Thanks. Jennifer Hi jyu2, sorry for a late reply, and yes I will fix it. Thanks for pointing this out. Repository: rG LLVM Github Monore

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

jyu2 added a comment. Hi @sandeepkosuri, do you plan to fix this? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 ___ cfe-commits mailing lis

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

jyu2 added a comment. In D127855#3956014 , @sandeepkosuri wrote: > As I do not have commit access, can someone commit this patch, now that it > passes the pre-merge tests ? I see some tests failed after this patch. Failed only with -fopenmp-vesion=51

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added a comment. As I do not have commit access, can someone commit this patch, now that it passes the pre-merge tests ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 ___ cfe-commits

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10634 "OpenMP constructs may not be nested inside an atomic region">; +def err_omp_prohibited_region_order +: Error<"construct %0 not allowed in a region associated with a dir

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10634 "OpenMP constructs may not be nested inside an atomic region">; +def err_omp_prohibited_region_order +: Error<"construct %0 not allowed in a region associated with a directive

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added inline comments. Comment at: clang/include/clang/Sema/Scope.h:483-488 + /// Determine whether this scope is some OpenMP directive with + /// order clause which specifies concurrent scope. + bool isOpenMPOrderClauseScope() const{ +return getFlags() & Sco

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

ABataev added a comment. provide full context of the changes. Comment at: clang/include/clang/AST/OpenMPClause.h:7646 - /// A kind of the 'default' clause. + /// A kind of the 'order' clause. OpenMPOrderClauseKind Kind = OMPC_ORDER_unknown; Commit as NFC