This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf1b18a79b7f4: [analyzer][NFC] Remove dead code and modernize
surroundings (authored by steakhal).
Repository:
rG LLVM Github Monorepo
CHANGES SIN
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127836/new/
https://reviews.llvm.org/D127836
_
steakhal added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:931-934
+ // void *getTag() const {
+ // static int Tag = 0;
+ // return static_cast(&Tag);
+ // }
martong wrote:
> Why should we keep this?
Accident xD
Repo
steakhal updated this revision to Diff 437120.
steakhal added a comment.
remove dead code from MallocChecker
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127836/new/
https://reviews.llvm.org/D127836
Files:
clang/lib/StaticAnalyzer/Checkers/Basi
martong added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:931-934
+ // void *getTag() const {
+ // static int Tag = 0;
+ // return static_cast(&Tag);
+ // }
Why should we keep this?
Repository:
rG LLVM Github Monor
steakhal created this revision.
steakhal added reviewers: kazu, martong, xazax.hun, gamesh411.
Herald added subscribers: abrachet, manas, ASDenysPetrov, phosek, dkrupp,
donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet,
baloghadamsoftware.
Herald added a reviewer: Szelethus.
Her
