> On Sep 16, 2015, at 4:01 PM, NAKAMURA Takumi wrote:
>
> Did you forget to update examples/analyzer-plugin? Fixed in r247862.
Yes — thank you!
Devin
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
chapuni added a subscriber: chapuni.
chapuni added a comment.
Did you forget to update examples/analyzer-plugin? Fixed in r247862.
Repository:
rL LLVM
http://reviews.llvm.org/D12780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247859: [analyzer] Add generateErrorNode() APIs to
CheckerContext. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D12780?vs=34917&id=34930#toc
Repository:
rL LLVM
http://r
xazax.hun added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:328
@@ -290,1 +327,3 @@
+// DereferenceChecker, CallAndMessageChecker, and DynamicTypePropagation)
+// rely upon the defensive behavior and would need to be update
dcoughlin added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:321
@@ +320,3 @@
+// sink, we assume that a client requesting a transition to a state that is
+// the same as the predecessor state has made a mistake. We return t
dcoughlin updated this revision to Diff 34917.
dcoughlin added a comment.
Added checks for null generated error nodes in the few cases in checkers were
they were missing and updated comments.
http://reviews.llvm.org/D12780
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:321
@@ +320,3 @@
+// sink, we assume that a client requesting a transition to a state that is
+// the same as the predecessor state has made a mistake. We return t
dcoughlin marked 3 inline comments as done.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:229
@@ -228,2 +228,3 @@
+ /// checkers should use generateErrorNode() instead.
ExplodedNode *generateSink(ProgramStateRef State = nullptr,
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:244
@@ +243,3 @@
+ const ProgramPointTag *Tag = nullptr) {
+return generateSink(State, /*Pred=*/nullptr,
+ (Tag
jordan_rose added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/FixedAddressChecker.cpp:53
@@ -52,3 +52,3 @@
- if (ExplodedNode *N = C.addTransition()) {
+ if (ExplodedNode *N = C.generateNonFatalErrorNode()) {
if (!BT)
zaks.anna wrote:
> Can t
xazax.hun added a comment.
In general I like this change, the node handling of the checkers are more
readable and reflects the intent in a clearer way. I have some comments inline.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:244
@@ +243,3 @@
+
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:229
@@ -228,2 +228,3 @@
+ /// checkers should use generateErrorNode() instead.
ExplodedNode *generateSink(ProgramStateRef State = nullptr,
jordan_rose added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:321
@@ +320,3 @@
+// sink, we assume that a client requesting a transition to a state that is
+// the same as the predecessor state has made a mistake. We return
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, krememek.
dcoughlin added subscribers: jordan_rose, cfe-commits, xazax.hun.
The analyzer trims unnecessary nodes from the exploded graph before reporting
path diagnostics. However, in some cases it can trim all nodes (includin
14 matches
Mail list logo
