[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce7b4747e8b3: [AArch64] Define __ARM_FEATURE_RCPC (authored by mingmingl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl added a comment. Thanks! Going to submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127798/new/ https://reviews.llvm.org/D127798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl added a comment. Hi folks, The ARM ACLE PR (https://github.com/ARM-software/acle/pull/199) was accepted. Would you take another look of this patch at your convenience? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127798/new/

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 461588. mingmingl added a comment. It has been a while since this patch was updated, rebase for review now that the Github PR was accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127798/new/ https://r

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 437750. mingmingl added a comment. Use `--target=aarch64` rather than `--target=aarch64-unknown-linux-gnu`, given the former means all ELF based operating systems can expect the feature. (thanks maskray@ for pointing it out!) Repository: rG LLVM Github

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 437749. mingmingl marked an inline comment as done. mingmingl added a comment. change from `-target=aarch64-none-linux-gnu` to `--target=aarch64-none-linux-gnu` to resolve a compile error. Verified no other compilation error by `ninja check-all` Reposito

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl marked an inline comment as done. mingmingl added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:22 // CHECK-NOT: __ARM_FEATURE_CRC32 1 +// CHECK-NOT: __ARM_FEATURE_RCPC 1 // CHECK-NOT: __ARM_FEATURE_CRYPTO 1 MaskRay wr

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 437691. mingmingl marked an inline comment as done. mingmingl added a comment. In clang/test/Preprocessor/aarch64-target-features.c, move `__ARM_FEATURE_RCPC` to keep the alphabetical list, and use `-target=aarch64..` (the join style) rather than legacy wh

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

MaskRay added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:22 // CHECK-NOT: __ARM_FEATURE_CRC32 1 +// CHECK-NOT: __ARM_FEATURE_RCPC 1 // CHECK-NOT: __ARM_FEATURE_CRYPTO 1 The list is alphabetical. RCPC should be moved below.

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl added a comment. In D127798#3588283 , @lenary wrote: > Yes. Please submit a PR or Issue to the ACLE, explaining the use-case (the > explanation here is good enough, I think). > > Once the ACLE changes are merged, then you can proceed with a pat

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

lenary added a comment. Yes. Please submit a PR or Issue to the ACLE, explaining the use-case (the explanation here is good enough, I think). Once the ACLE changes are merged, then you can proceed with a patch for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl added a comment. In D127798#3585025 , @tyb0807 wrote: > The patch looks correct to me, but looking at > https://github.com/ARM-software/acle/blob/main/main/acle.md where all the > ACLE macros are defined, I'm not sure that `__ARM_FEATURE_RCPC`

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

tyb0807 added a comment. The patch looks correct to me, but looking at https://github.com/ARM-software/acle/blob/main/main/acle.md where all the ACLE macros are defined, I'm not sure that `__ARM_FEATURE_RCPC` is there currently. Maybe you also want to submit a patch there, or at least explain t

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 436940. mingmingl added a comment. update commit message with differential revision link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127798/new/ https://reviews.llvm.org/D127798 Files: clang/lib/Basic/T

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. mingmingl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements the definition of __ARM_FEATURE_RCPC when clang commands