[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28b5f3087a3f: [Clang][AArch64] Add/implement ACLE keywords for SME. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D12

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

rsandifo-arm accepted this revision. rsandifo-arm added a comment. LGTM too, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/ https://reviews.llvm.org/D127762 ___ cfe-commits mailing lis

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 547696. sdesmalen added a comment. Added `enum AArch64SMECallConversionKind` to make it explicit when calling `IsInvalidSMECallConversion` whether or not 'preserves_za' can be dropped (e.g. in assignment), can be added (e.g. when overriding a parent method)

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

rsandifo-arm added a comment. Thanks for dropping the attribute requirements down to TargetAArch64. But the offsetting requirement was that something somewhere (CodeGen?) must raise an error if code requires SME and SME isn't present. I think that means: 1. SME is not enabled for an `__arm_st

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please give other active reviewers a bit of time to chime in before landing. Note, @erichkeane is out on sabbatical at the moment, so there's no need to wait for his

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen added a comment. Thanks both for the detailed review and latest round of comments, I've tried to address them all. Comment at: clang/include/clang/AST/Type.h:3987 /// [implimits] 8 bits would be enough here. -uint16_t NumExceptionType = 0; +uint16_t NumE

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 546479. sdesmalen marked 19 inline comments as done. sdesmalen added a comment. - The attributes no longer require +sme to be passed. - Fixed IsInvalidSMECallConversion to consider the correct To/From types and added a corresponding test for the virtual ove

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

aaron.ballman added a comment. In D127762#4515055 , @sdesmalen wrote: > Gentle ping @aaron.ballman and @erichkeane. I've addressed all comments and > suggestions and believe we found agreement on the approach (to use a keyword > instead of an attribute)

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

rsandifo-arm added a comment. Mostly LGTM from a spec POV, but some comments below. Comment at: clang/include/clang/Basic/Attr.td:2439 def ArmStreaming : TypeAttr, TargetSpecificAttr { let Spellings = [RegularKeyword<"__arm_streaming">]; In current main,

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen added a comment. Gentle ping @aaron.ballman and @erichkeane. I've addressed all comments and suggestions and believe we found agreement on the approach (to use a keyword instead of an attribute). Are you happy to accept the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + erichkeane wrote: > sdesmalen wrote: > > erichkeane wrote: > > > sdesmalen wrote: > > > > er

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 536260. sdesmalen marked 11 inline comments as done. sdesmalen added a comment. Updated patch: - Addressed review comments (clarified documentation, minor refactoring) - Added new tests (codegen + sema tests to make sure attributes are propagated to types

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

erichkeane added a comment. I think we need a few tests to ensure that these are properly propagated on function templates (both for Sema and codegen). Also, a handful of nits (See my list). Comment at: clang/include/clang/AST/Type.h:3958 +SME_PStateZAPreservedMask = 1 <

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen marked an inline comment as done. sdesmalen added a comment. In D127762#4395509 , @erichkeane wrote: > We ended up getting the regular-attribute-like-keywords patch in a different > form. Do we still want to do this as is? Does it need rebas

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

erichkeane added a comment. We ended up getting the regular-attribute-like-keywords patch in a different form. Do we still want to do this as is? Does it need rebasing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/ https://reviews.ll

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

erichkeane added a subscriber: ChuanqiXu. erichkeane added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + sdesmalen wrote: > erichkeane wrote: > > sdesmale

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen marked 4 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + erichkeane wrote: > sdesmalen wrote: > > erichke

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 528376. sdesmalen marked 15 inline comments as done. sdesmalen added a comment. - Use only 6 bits for AArch64SMEAttributes to reduce the size of ExtProtoInfo. - Added test for implicit instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 528366. sdesmalen retitled this revision from "[Clang][AArch64] Add ACLE attributes for SME." to "[Clang][AArch64] Add/implement ACLE keywords for SME.". sdesmalen edited the summary of this revision. sdesmalen added a comment. - Rebased patch after patch t