[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu added a comment. In D127471#3580581 , @akuegel wrote: > It seems this change triggers a warning: > > https://buildkite.com/llvm-project/upstream-bazel/builds/31190#018160e2-0b96-4254-8986-f039b7f2e0a1 > > llvm-project/llvm/lib/Transforms/Utils/C

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

akuegel added a comment. It seems this change triggers a warning: https://buildkite.com/llvm-project/upstream-bazel/builds/31190#018160e2-0b96-4254-8986-f039b7f2e0a1 llvm-project/llvm/lib/Transforms/Utils/CodeExtractor.cpp:901:15: error: enumeration value 'PresplitCoroutine' not handled in swit

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG735e6c40b5e9: [Coroutines] Convert coroutine.presplit to enum attr (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

rjmccall accepted this revision. rjmccall added a comment. LGTM. Don't worry about Swift, we'll handle it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127471/new/ https://reviews.llvm.org/D127471 ___

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu added a comment. @rjmccall Does this look good to you? I am afraid to break swift's codes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127471/new/ https://reviews.llvm.org/D127471 ___ cfe-com

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ezhulenev accepted this revision. ezhulenev added a comment. This revision is now accepted and ready to land. Yes, that's the correct MLIR way of passing attributes to LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127471/new/ https://reviews.

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu added a comment. In D127471#3572616 , @nikic wrote: > You probably want to add this to `llvm::UpgradeAttributes` as well, to > maintain support for old bitcode. Oh, I feel like it is not so meaningful to keep backward compatibility. We've don

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

nikic added a comment. You probably want to add this to `llvm::UpgradeAttributes` as well, to maintain support for old bitcode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127471/new/ https://reviews.llvm.org/D127471 ___

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu created this revision. ChuanqiXu added reviewers: nikic, rjmccall, ezhulenev. Herald added subscribers: Peiming, bzcheeseman, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb