hokein added inline comments.
Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:298
auto Pop = [&](const GSS::Node *Head, RuleID RID) {
-LLVM_DEBUG(llvm::dbgs() << " Pop " << Params.G.dumpRule(RID) << "\n");
-const auto &Rule = Params.G.lookupRule(RID);
+LLVM_DEBUG
hokein updated this revision to Diff 441680.
hokein marked 5 inline comments as done.
hokein added a comment.
fix format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127448/new/
https://reviews.llvm.org/D127448
Files:
clang-tools-extra/pseudo/
hokein updated this revision to Diff 441677.
hokein marked 8 inline comments as done.
hokein added a comment.
rebase and address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127448/new/
https://reviews.llvm.org/D127448
Files:
clang-to
sammccall added a comment.
(comments for guard part)
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Language.h:22
+
+// Interface for implementing the grammar "guard" attribute.
+//
nit: I think the first sentence should try to describe what this *is
sammccall added a comment.
The ParseLang + CLI library seem clearly separate from everything else, I think
this patch should be split.
Comments on that part first...
Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:68
for (auto _ : State)
-LRTable::buildSL
hokein updated this revision to Diff 435889.
hokein added a comment.
- add comments;
- add unittest and lit test;
- misc improvements;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127448/new/
https://reviews.llvm.org/D127448
Files:
clang-tools-
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a subscriber: mgorny.
Herald added a project: All.
hokein requested review of this revision.
Herald added subscribers: cfe-commits, alextsao1999.
Herald added a project: clang-tools-extra.
- define a common data structu
